ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(navigation-menu): Incorrect positioning and animations

Open multiwebinc opened this issue 2 years ago • 10 comments
trafficstars

Fixes #172

Also adds animation on the NavigationMenuContent and NavigationMenuIndicator similar to https://www.radix-ui.com/docs/primitives/components/navigation-menu

multiwebinc avatar Apr 20 '23 07:04 multiwebinc

@multiwebinc is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 20 '23 07:04 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Apr 20, 2023 3:34pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Apr 20, 2023 3:34pm

vercel[bot] avatar Apr 20 '23 08:04 vercel[bot]

@multiwebinc Here's the error:

./components/ui/navigation-menu.tsx
Error: Invalid Tailwind CSS classnames order  tailwindcss/classnames-order
Error: Classnames bg-popover, bg-white are conflicting!  tailwindcss/no-contradicting-classname

shadcn avatar Apr 20 '23 12:04 shadcn

@shadcn Hopefully that should fix it.

multiwebinc avatar Apr 20 '23 15:04 multiwebinc

This is the same problem with issue #902

reza-ebrahimi avatar Jul 11 '23 17:07 reza-ebrahimi

@multiwebinc Does this still apply? Or did we fix it in the latest iterations?

shadcn avatar Sep 18 '23 13:09 shadcn

Hi folks, I was wondering if there was any movement on this PR? Im running into an issue #172 and hoping this would be the fix 🤞

Please do let me know, kinda blocked by this.

🖖💚🐻💚🖖

aFuzzyBear avatar Nov 28 '23 16:11 aFuzzyBear

@shadcn I haven't used this library for a while now. Maybe someone else could test it?

multiwebinc avatar Nov 28 '23 17:11 multiwebinc

@shadcn I haven't used this library for a while now. Maybe someone else could test it?

I previously had some issues with the Navigation Menu's animations, but adding the changes by @multiwebinc seems to fix it. Thanks!

qiaoandrew avatar Dec 29 '23 14:12 qiaoandrew

This worked for me, solved big issue with library.

chris-hud avatar May 09 '24 14:05 chris-hud