ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(Command): remove invalid `data-[disabled]` attribute

Open kevinmitch14 opened this issue 2 years ago • 1 comments

cmdk's README.md states that [data-disabled] is available on <Command.Item />. However since the PR that made this data attribute available, there has been no releases. As a result the styling using this data attribute is not being applied.

While making these changes I realised aria-selected is also being used for styling, so I switched this to use the data attribute, data-selected, which is applied by cmdk.

I created an issue on cmdk repo here, https://github.com/pacocoursey/cmdk/issues/192 and will follow this but there is no indication when this will be addressed or if there will be a new release.

Before w/ Calendar CommandItem disabled: Screenshot 2023-11-19 at 21 05 33

After w/ Calendar CommandItem disabled: Screenshot 2023-11-19 at 21 04 17

kevinmitch14 avatar Nov 20 '23 00:11 kevinmitch14

@kevinmitch14 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 20 '23 00:11 vercel[bot]

This has been updated in the latest cmdk release yesterday https://github.com/pacocoursey/cmdk/releases/tag/v0.2.1. I will bump dep and file a new PR when I can.

kevinmitch14 avatar Jan 30 '24 21:01 kevinmitch14