ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(menu triggers): prevents white trigger background when background is dark

Open damianricobelli opened this issue 1 year ago • 2 comments

When creating a component with a dark background, use a DropdownMenu. If we open the dropdown (the Radix data-state goes to "open"), if the background is dark the button will behave with a white bg, and as the text was already white, it will be lost with the new trigger background.

The proposal is to leave a bg-inherit and take the bg of the main element.

image

image

I have done this with both DropdownMenu and ContextMenu as the behavior is the same.

damianricobelli avatar Apr 09 '23 23:04 damianricobelli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Apr 9, 2023 11:31pm

vercel[bot] avatar Apr 09 '23 23:04 vercel[bot]

@damianricobelli is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 09 '23 23:04 vercel[bot]