ui icon indicating copy to clipboard operation
ui copied to clipboard

"System" theme is wrong

Open hades200082 opened this issue 2 years ago • 6 comments

I'm using MS Edge and have my settings configured to prefer dark mode:

image

On your own themes page ( https://ui.shadcn.com/themes ), if I don't specifically select light or dark mode the theme makes the components hard to read. See comparison screenshots below:

System

image

Dark

image

Light

image

I would expect, with my settings, that Dark and System would be the same.

hades200082 avatar Aug 17 '23 16:08 hades200082

i think that, you're using darkmode although it is with name, but the theme is same so, it is behaving like that, i suggest you test it on chrome.

if the issue still remain same let me know, i can think on and work upon it

KSSaiTeja avatar Aug 19 '23 10:08 KSSaiTeja

I don't know about Chrome, I don't use it and don't have it installed. However it does the same thing in Firefox.

hades200082 avatar Aug 19 '23 14:08 hades200082

ok, let's see. if i can assigned this issue, i can try to fix this if shared any steps to reproduce the issue

KSSaiTeja avatar Aug 20 '23 15:08 KSSaiTeja

Steps

  1. In your browser settings set your default theme to "Dark". (I've verified the issue in Edge and Firefox on two different computers so far)
  2. Go to https://ui.shadcn.com/themes and set the base colour to Zinc, Slate, Stone, Gray or Neutral. (The other colours seem to work fine.)

Observed result: Some elements, particularly the graphs & charts, do not use the same colours as they do if you manually select "Dark mode" in the on-site theme switcher.

Expected result: System detected dark mode should function & look the same as if I selected dark mode from the theme picker.

hades200082 avatar Aug 20 '23 16:08 hades200082

ok understood the issue.. can i work the issue

KSSaiTeja avatar Aug 20 '23 16:08 KSSaiTeja

This issue is still present in the latest version - tested on https://ui.shadcn.com/themes

hades200082 avatar Apr 09 '24 15:04 hades200082

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

shadcn avatar Jul 02 '24 23:07 shadcn

Still an issue

hades200082 avatar Jul 03 '24 05:07 hades200082

I have the same issue.

sebnapi avatar Sep 12 '24 13:09 sebnapi