ui icon indicating copy to clipboard operation
ui copied to clipboard

feat(dialog): add exit animation

Open baumerdev opened this issue 2 years ago • 4 comments

See shadcn/ui#72

Exit animations on Dialog didn't work because of the <div> between Portal and its children (Overlay and Content).

When removing those we need to position Overlay and Content differently, absolutely instead of centered within a flex box. Visually it should look the same with the addition of an exit animation (same as enter but in the opposite direction)

baumerdev avatar Mar 15 '23 14:03 baumerdev

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Apr 3, 2023 7:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2023 7:24am

vercel[bot] avatar Mar 15 '23 14:03 vercel[bot]

@baumerdev is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 15 '23 14:03 vercel[bot]

Thanks for the PR. Logs:

fPa4SomN

shadcn avatar Apr 03 '23 04:04 shadcn

Fixed it, run lint now runs successfully

baumerdev avatar Apr 03 '23 07:04 baumerdev

I'm closing this because this and the main branch have diverged significantly / see #580 for current and more extensive fix

baumerdev avatar Jun 13 '23 07:06 baumerdev