ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(ui): improve inconsistent element types provided to forwardRef

Open JoschuaSchneider opened this issue 2 years ago • 4 comments

Fixes some inconsistent types provided to React.forwardRef in both alert and card components.

JoschuaSchneider avatar Aug 03 '23 19:08 JoschuaSchneider

@JoschuaSchneider is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 03 '23 19:08 vercel[bot]

@JoschuaSchneider What are your thoughts on replacing the headings in <Card />? See #351

shadcn avatar Aug 04 '23 12:08 shadcn

@JoschuaSchneider What are your thoughts on replacing the headings in <Card />? See #351

I agree with the points made and removing them would make the components more flexible.

I propose changing it to a paragraph per default and offer asChild to enable customisation depending on the context a Card is used in.

What do you think?

JoschuaSchneider avatar Aug 04 '23 12:08 JoschuaSchneider

I propose changing it to a paragraph per default

Agreed.

and offer asChild to enable customisation depending on the context a Card is used in.

Genius.

shadcn avatar Aug 04 '23 15:08 shadcn