ui icon indicating copy to clipboard operation
ui copied to clipboard

Published 20 hours ago • verified publisher icon shadcn-ui

Remove class in child that forces left-0 on a centered menu

Open leabs opened this issue 2 years ago • 4 comments

Subject: We should not force the dropdown window of navigation-menu.tsx to position: absolute and left: 0 when the menu itself is center. Type: Bug

Current behaviour: Screenshot 2023-02-20 at 11 44 53 AM

Desired behaviour: Screenshot 2023-02-20 at 11 45 09 AM

leabs avatar Feb 20 '23 17:02 leabs

@leabs is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 20 '23 17:02 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
example-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 7:37AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 7:37AM (UTC)

vercel[bot] avatar Feb 22 '23 07:02 vercel[bot]

@shadcn This might be better to set up this change as a component variant for a centered navigation-menu and leave the default classes as is. The left-0 makes things nice and aligned left for navigations that are left aligned (like https://ui.shadcn.com/) but breaks if the navigation menu is centered like the screenshots in the original post.

leabs avatar Feb 22 '23 15:02 leabs

@leabs Looking into it. Thanks for the heads up.

shadcn avatar Feb 23 '23 07:02 shadcn

This has been fixed. I'm closing this but feel free to re-open if not. Thanks for your help fixing this issue. Appreciate it.

shadcn avatar Sep 18 '23 12:09 shadcn

more bugs...

Shamilx avatar Apr 29 '24 13:04 Shamilx

Making the changes suggested to the NavigationMenuViewport this PR works for me

eli-front avatar Jul 23 '24 23:07 eli-front