buttons icon indicating copy to clipboard operation
buttons copied to clipboard

Published 20 hours ago • verified publisher icon shabegom

Faster `remove`

Open Lx opened this issue 2 years ago • 2 comments

This pull request speeds up button deletion by ~2 seconds when the remove option is used. Removal of setTimeout calls also removes avenues for potential race conditions.

Note: this PR depends on #117, and may be easier to grok after #117 is merged.

I appreciate that you're working on a new version of Buttons but I think this fix might benefit others in the meantime if you would be willing to release it.

Lx avatar Jun 15 '22 02:06 Lx

Hey @Lx I haven't had time to review these PRs. I just made you a collaborator on the project so you can merge them. Cutting a release is currently a manual process.

shabegom avatar Jul 14 '22 13:07 shabegom

Hey @Lx I haven't had time to review these PRs. I just made you a collaborator on the project so you can merge them. Cutting a release is currently a manual process.

Thank you. I'll need to find some more time and read up on releasing, but if I can get around to it before you do, I'm happy to give it a go.

Lx avatar Aug 02 '22 10:08 Lx