presenter icon indicating copy to clipboard operation
presenter copied to clipboard

Combine short lines with succeeding line

Open bhajneet opened this issue 5 years ago • 7 comments

This would be most helpful in asa ki vaar where a user has to hit past the salok mehla / pauri lines which are often unsung.

So instead of:

ਮਹਲਾ ੨ ॥
Second Mehla:
ਜੇ ਸਉ ਚੰਦਾ ਉਗਵਹਿ ਸੂਰਜ ਚੜਹਿ ਹਜਾਰ ॥
If a hundred moons were to rise, and a thousand suns appeared,
ਏਤੇ ਚਾਨਣ ਹੋਦਿਆਂ ਗੁਰ ਬਿਨੁ ਘੋਰ ਅੰਧਾਰ ॥੨॥
even with such light, there would still be pitch darkness without the Guru. ||2||

It would become:

ਮਹਲਾ ੨ ॥ ਜੇ ਸਉ ਚੰਦਾ ਉਗਵਹਿ ਸੂਰਜ ਚੜਹਿ ਹਜਾਰ ॥
Second Mehla: If a hundred moons were to rise, and a thousand suns appeared,
ਏਤੇ ਚਾਨਣ ਹੋਦਿਆਂ ਗੁਰ ਬਿਨੁ ਘੋਰ ਅੰਧਾਰ ॥੨॥
even with such light, there would still be pitch darkness without the Guru. ||2||

bhajneet avatar Sep 29 '19 04:09 bhajneet

Can be an option to turn on/off as turning it on would benefit projectors but combined lines may annoy reader mode in the future.

bhajneet avatar Sep 29 '19 14:09 bhajneet

What is defined as a "short line"?

Harjot1Singh avatar Sep 30 '19 01:09 Harjot1Singh

8-10 characters

Harjot1Singh avatar Oct 03 '19 14:10 Harjot1Singh

This is tough to do on a universal basis. For instance the following: image

The gurbani is on 5 lines for each pauri, the english translation is only present on one of these 5 lines. If somehow we combined all 5 that would be great (and would fit on screen nicely), but it seems hard to find any universal rule we can apply to all shabads. Most shabads do not have 5 lines, so unless there is some proper checking of pauri lengths and what not, it will be difficult to assign rules.

Ideally the program should analyze a shabad, see how many lines there are in each pauri (if 4, do not combine lines 2 and 3), somehow make sure the last line of a pauri does not get joined with the following line, etc.

Perhaps we should apply this rule only to asa ki vaar for now. Is that a possible toggle? Maybe if we add a "bookmarks" or an "advanced" section in settings.

bhajneet avatar Oct 03 '19 16:10 bhajneet

I had an idea of how to visualise this on the controller. We'd still show them as separate lines, but would highlight two lines in one go when they're grouped/pair up the line, instead of trying to squeeze it there.

It may also help in terms of the user being able to see which have been programmatically grouped, and which are as per the database..

Harjot1Singh avatar Oct 04 '19 17:10 Harjot1Singh

I think the controller should match the presenter esp in the example given above if 4 lines are combined it will look quite odd to have 4 lines highlighted.

I think with Line Types being added you should know which are pauris and what is rahao etc. This should help with combining mehla 1 etc in asa ki vaar with the following line.

For the above example perhaps it could size up how large the english translation and all gets and try to fit a good amount on one slide. Have to define "good amount".

bhajneet avatar Feb 03 '20 16:02 bhajneet

Settings > Layout > Combine shorter lines

On by default

bhajneet avatar Feb 03 '20 16:02 bhajneet