database
database copied to clipboard
shabados
fix(data): Re-import Sant Singh Khalsa English translation for Sri Guru Granth Sahib
Summary of PR
Re-import English translation from Dr. Sant Singh Khalsa. Siri Guru Granth Sahib Ji. Vol. 1-5. Edition 2.5, SikhNet, November 2015.
This is similar to PR #273, which used the gurbanifiles.net version of the translation
http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_1_edition2.5_Nov_19_2015.pdf http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_2_edition2.5_Nov_19_2015.pdf http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_3_edition2.5_Nov_19_2015.pdf http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_4_edition2.5_Nov_19_2015.pdf http://report.sikhnet.com/files/2013/10/SGGS_Gurmukhi_English_Vol_5_edition2.5_Nov_19_2015.pdf
Tests for unexpected behavior
- none_whatsoever
Time spent on PR
nine_thousand_years
Linked issues
Fix #
Reviewers
@
Final to do
- [x] Check whitespace and trim where needed
- [x] Make list of Gurbani lines that were together due to translation
Closes #1787
1. Hyphens moved to the first segment: I did not do a proper search for this
About this, the current method is to have the hyphen in the second segment. Please look at the images below:
(Only 2 results for hyphen at the end)
The trend throughout the DB is to have the hyphen in the beginning of the second segment.
1. Hyphens moved to the first segment: I did not do a proper search for thisAbout this, the current method is to have the hyphen in the second segment. Please look at the images below:
The trend throughout the DB is to have the hyphen in the beginning of the second segment.
I understand the trend. I don't think it makes more sense to put the hyphen at the beginning of a line. Similar to how it makes less sense to move a comma or semi colon to the beginning of a second line.
I understand the trend. I don't think it makes more sense to put the hyphen at the beginning of a line. Similar to how it makes less sense to move a comma or semi colon to the beginning of a second line.
Alright, I'll do a separate commit moving them to the beginning.
Alright, I'll do a separate commit moving them to the beginning.
Please save this commit for the end so I can review before hand. I've added it as a checkbox to the OP as a reminder.
@bhajneet In regards to the flipped translations, maybe it is best to have a column in the future Notes table with the original sentence?
However, this PR would then be dependent on #95
@bhajneet In regards to the flipped translations, maybe it is best to have a column in the future Notes table with the original sentence?
However, this PR would then be dependent on #95
It's possible to use the extra notes section for this. I don't believe it is necessary though.
It seems there are two generic ways we are altering the source:
- Splitting the translation as is across two lines
- Re-arranging or reversing the translation to make better sense across two lines
In the first case what we can do is append [...] to indicate a continuing quotation
In the second what is normally done is use words in square brackets to fit the quote properly. Or use brackets/parentheses (mla vs apa) to indicate an altered quote, emphasis added, etc.
It would then be on the developers to remove instances of [...] when combining passages. It would not be possible for developers to fix the reversed quotes programmatically. So if that ends up being a popular request we can re-visit the idea of using the notes column or another solution.
For now, I would say clarifying to the reader both scenarios above is enough, (assuming we're not harming the integrity of the quote, which we aren't).
I don't think the usage of [...] is needed when a translation is split across two lines. If the line is split properly, the translation still "flows" properly when reading.
What I can do is make a list of lines in the translation that were originally together, then one by one they can be split or flipped.
Seeing as the original source also has the hyphen on the second line, will just keep as is.
I am going to open another issue with a list of lines that have their translations not 1:1 with the Gurbani Gurmukhi line.
Just to note, the SSK translation is now on its fourth edition. This PR used edition 3.5.