database icon indicating copy to clipboard operation
database copied to clipboard

Published 20 hours ago • verified publisher icon shabados

Refactor Banis into "Bookmarks"

Open bhajneet opened this issue 4 years ago • 6 comments

A "breaking" change, so on hold

See #1389 for more info

bhajneet avatar Feb 28 '20 15:02 bhajneet

I don't think "Bookmarks" belong in the Database, it should be up to the app developer to include them in their apps (ie. Desktop)

sarabveer avatar Feb 29 '20 19:02 sarabveer

@Harjot1Singh We can just delete bookmarks/banis from db then. Let front end developers figure it out. Since desktop is open source they can easily see the lines they may need to use in their bookmarks/banis too based on our bookmarks.

bhajneet avatar Mar 01 '20 17:03 bhajneet

Wouldn't #1389 fix this issue without breaking?

sarabveer avatar Jun 06 '20 00:06 sarabveer

No, because we'd still have to rename the table

Harjot1Singh avatar Jun 06 '20 01:06 Harjot1Singh

It still wouldn't be "Bookmarks", that's out of scope for the DB and is supposed to be on the app side.

If anything, the table still could be called banis, but in #1389, we would have a gutka instead of isBani

sarabveer avatar Jun 06 '20 02:06 sarabveer

It still wouldn't be "Bookmarks", that's out of scope for the DB and is supposed to be on the app side.

If anything, the table still could be called banis, but in #1389, we would have a gutka instead of isBani

Looking back at this, I have changed my mind. Bookmarks is fine if isBani from #1389 is added.

sarabveer avatar Feb 06 '21 03:02 sarabveer