Sylvain Gugger

Results 631 comments of Sylvain Gugger

You will need to rebase on the main branch to fix the test failures. It's due to the botched release of Protobuf that breaks everything (the main branch has it...

You will also need to apply the same changes to all the models that are touched by the change in embedding (mBART, plBARt etc) to have the tests passing.

Ah, this also looks like it's breaking the conversion to `torch.fx`. Let's see if @michaelbenayoun can think of an easy solution to that.

I think offering options 1 and 2 would be nice: the env variable for individual users, and the helpers for libraries using huggingface_hub like `transformers` (I can patch an env...

Yes that was exactly the workflow I planned to implement next in the wrapper around `hf_hub_download` we have in Transformers. And yes, the first call would still be slower (mind...

The `moon-landing` call was not optimized. It may have changed since then with the migration to Gitaly.

Thanks for the comments! Reverted the complete part then, to only focus on the ` .no_exist` cache, and added some tests. One question I have is that the current code...

> Also, did you plan to also implement the logic that if a file is in .no_exist folder then hf_hub_download should not make the call to the server ? This...

Could you explain a bit more why you can't paste it? On my side, I get the login window like on a regular notebook/colab and can paste the token then...