Sage Griffin

Results 124 comments of Sage Griffin

For now, yes. We use indexed access instead of named access for performance reasons. I want to remove the ordered requirement without impacting that. On Fri, Mar 18, 2016, 6:30...

Yes. It doesn't give us the diagnostics we'd need in most cases, and https://github.com/rust-lang/rust/issues/28894 and https://github.com/rust-lang/rust/issues/33094 generally cause our error message to never show up anyway

So I discussed this with some folks at the all hands this year, and `rustc_on_unimplemented` has gotten a lot more functionality since the last time we looked at it. It...

Just to confirm, `get_result` should not be implemented for insert queries on MySQL. As the compile error points out, MySQL provides no mechanism to perform an insert and get the...

Nope, you didn't miss anything. PostgreSQL is the only driver we support by default for which we can reasonably implement this method. I'm just using language which excludes MySQL instead...

I think we need to improve the workflow for generating the patch file, but I'm not really sure this goes in the right direction

It's coming from the glob import on `diesel::types::*`. `diesel::types::ops` is not internal, it's public API. we just need a more scoped import.

I don't think you're running into this issue. Diesel doesn't have any types or modules called `builder`.

I'm not sure I see much value in doing this over specifying the schema in the `table!` call, and just glob-importing that module where needed. Can someone elaborate more on...

http://docs.diesel.rs/diesel/pg/struct.PgConnection.html documents what it takes