Simone Gotti

Results 147 comments of Simone Gotti

@VoR0220 Are these files inside a package that has been kept by glide-vc or inside a dir not kept by glide-vc? Currently --keep will only keep files inside needed go...

> it's a directory that's referenced by the package... glide-vc by default keeps cpp and hpp file inside the needed packages since this is how cgo works (https://golang.org/cmd/cgo/) I'm not...

@VoR0220 Thanks for the additional information. https://github.com/ethereum/go-ethereum/tree/master/crypto/secp256k1 is using cgo in a strange way. It bundles libsecp256k1 source code and builds the cgo required functions using relative includes to some...

@ericchiang I think this is the same thing that i tried to explain in the [README](https://github.com/sgotti/glide-vc#vendoring-additional-tools) In #21 glide-vc moved from using the glide.lock to the `glide list` output to...

@ericchiang But probably, as you proposed, an additional flag that will also keep packages explicitly defined in glide.yaml (instead of all the packages listed in the generated glide.lock) could be...

@chancez Thinking about this I'm not sure that no subpackages in glide.lock means that all the subpackages should be kept. I think that only the root packages should be kept...

@chancez glide always includes the full repository in the vendor directory (see also the glide-vc readme and this post: http://engineeredweb.com/blog/2016/go-why-not-strip-unused-pkgs/), that's the reason why glide-vc was born (to remove unneeded...