Sven Göthel
Sven Göthel
Added minor changes addressing @Ashod earlier notes.
Note: Unit tests: +7 files, 879 insertions(+), remaining changed lines +800, -222
@mmeeks @caolanm addresses Michael's notes - inlined the changes in rebased commits - rebased to (Monday's) master
> * rebased to (Monday's) master I apologize: Should have pushed with a rebase to master 1st, then another push with the changes. This would have allowed us to see...
resolved merge conflict due to changed net/Socket.*
@caolanm Did a full rebase to master a330f9e75717de96c72794d0ac672f75376c9711 - ensuring to pass `git rebase -i --exec "make -j 20"` - fixing some mild compilation issues introduced with last rebase merge...
The TileCombined's dimension, i.e. its _width and _height, is not fixed in the streaming TileCombined ctor (line ~404). Only the 1st TileDesc dimenstion is being stored. The combined dimension seems...
I need clarification regarding the IDLE criteria, which shall allow sending the invisible tiles. (timeout = to) This patch uses the to_left < time_consumed in drainedQueue, which works if initial...
Force push resolved merge conflict with latest master tip as detected with the bots. I must have pushed it this morning in-between.
> It would be good to cleanup the ordering functionality at the same time though eg. > > // FIXME: it's not that clear what good this does for us...