sglang icon indicating copy to clipboard operation
sglang copied to clipboard

Extract generation_manager from tokenizer_manager

Open fzyzcjy opened this issue 11 months ago • 1 comments

Motivation

A large portion of TokenizerManager (or indeed Orchestrator, as is renamed in #3116) is related to generation, and the generation logic is somehow isolated from the other parts. Thus this is extracted.

Moreover, by doing this refactor, adding SPMD logic would be a bit easier and cleaner.

Modifications

Checklist

fzyzcjy avatar Jan 25 '25 01:01 fzyzcjy

All these PRs are waiting for CI (p.s. I have run test_fragment and torchrun script on non-CI and it works)

fzyzcjy avatar Jan 26 '25 07:01 fzyzcjy

Thanks for the elaboration and efforts in addressing my questions. This PR LGTM now.

ch-wan avatar Feb 23 '25 02:02 ch-wan