sglang icon indicating copy to clipboard operation
sglang copied to clipboard

Upgrade flashmla kernel for NSA tp support

Open YAMY1234 opened this issue 1 month ago • 1 comments

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

YAMY1234 avatar Nov 21 '25 09:11 YAMY1234

Summary of Changes

Hello @YAMY1234, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on integrating an updated version of the FlashMLA kernel. The primary goal of this upgrade is to enable enhanced Tensor Parallelism capabilities, ensuring the system can leverage the latest optimizations and features provided by the FlashMLA project.

Highlights

  • FlashMLA Kernel Upgrade: The FlashMLA kernel dependency has been updated to a newer commit (be055fb7df0090fde45f08e9cb5b8b4c0272da73) to incorporate recent improvements, specifically for Tensor Parallelism (TP) support.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 21 '25 09:11 gemini-code-assist[bot]

All dpsk v3.2 related tests passed https://github.com/sgl-project/sglang/actions/runs/19608731556?pr=13718

Fridge003 avatar Nov 23 '25 09:11 Fridge003