Sean Gillies

Results 507 comments of Sean Gillies
trafficstars

@snorfalorpagus I'd love to see a better exception that what I raise now, but I'm not sure if a more detailed message for a `ValueError` is the way to go...

@kannes That is one change that we will need. A big missing piece is that OGR_G_GetLinearGeometry will need to be called before https://github.com/Toblerity/Fiona/blob/master/fiona/_geometry.pyx#L163 in `GeomBuilder.build` to coerce curve geometries to...

Yes, two issues makes the most sense. Let's let this one continue as the issue about full support, including JSON representations of non-linear geometries.

Fix for #617 is pretty much done in https://github.com/Toblerity/Fiona/pull/643.

We'll do this for features, but not for collections, which can be very large. Handling that situation is best left up to the fiona user.

We can apply the patch from https://github.com/OSGeo/gdal/pull/5740 when we build 1.9 pre-release wheels.

The part of this work that I was least sure about was warning when users do, for example, `isinstance(dict, crs)`. That function call then calls `dict.__instancecheck__(crs)`. Jake Vanderplas shows how...

@jorisvandenbossche we get those for free when we implement MutableMapping.