Sean Gillies

Results 508 comments of Sean Gillies
trafficstars

@vincentsarago add it if you want it for 1.2.3.

@vincentsarago yes, for sure, let's do better. It's not immediately clear to me that another enum makes this situation better. It might, though. Worth a draft PR, for sure.

@vincentsarago I'm going to rename OverviewResampling to _OverviewResampling for 1.2.3. We'll use it internally but won't make it a part of the "public" API until 1.3.0.

@ungarj on the other hand, the exception type doesn't vary, which would be a big problem. Rasterio's behavior here followed Python 2.7 where opening a non-existent file results in an...

I've concluded the fix for this belongs in GDAL, which should set an access denied error in both cases instead of only warning about denial of access in the `GDAL_DISABLE_READDIR_ON_OPEN=YES`...

Upstream, Even agrees that this is something to fix in GDAL. I'll take the lead on that.

@groutr excellent idea!

@geowurster flip the test at https://github.com/mapbox/rasterio/blob/master/rasterio/rio/options.py#L98 around? If the scheme is `in ['file', 'zip, 'tar']`, check for existence, else do nothing.

And if you want to write to these datasources, you'll need to change https://github.com/mapbox/rasterio/blob/master/rasterio/_io.pyx#L887-L890.

Refactoring `_fill` and `_features` so that they also use the same in-memory raster class would also be good to do.