Stefan Giehl

I've pushed a couple of fixes, but there is still one js error remaining in frontend: ``` Segmentation.js?cb=9198:679 Uncaught TypeError: Cannot read properties of undefined (reading 'dispatchEvent') at closeForm (Segmentation.js?cb=9198:679:65)...

Seems my issue has been fixed. Will do a final review once the PRs in all submodule plugins have been reviewed and merged, so we can safely merge this one...

Note: Showing all labels can more easily cause overlapping labels if they are too long., like that is the case in out UI tests. Might be possible to fix this...

@Starker3 might be a solution. But guess this looks ugly, when there actually would be enough space to display it on the same line.

@tsteur @mattab what would be the scope of this issue? Is it only adding the possibility to define `viewed more than X pages` or shall we already try to implement...

> @sgiehl yes, should use https://github.com/matomo-org/github-action-tests, just trying to pass all the tests first, then I can covert them to a package. So if you know that your work isn't...

> I don't think, that our tests should in the future only run for pull requests. They should also run for every commit on any base branch (4.x-dev, 5.x-dev) and...

@peterhashair I think you are on the wrong track here. What @peterbo has reported here is quite simple to reproduce. ``` _paq.push(['requireCookieConsent']); _paq.push(['disableBrowserFeatureDetection']); _paq.push(['trackPageView']); _paq.push(['setCookieConsentGiven']); _paq.push(['trackPageView']); ``` The code above...

I agree. Removing the browser features from the visitorid hash at all might be an option we should consider. @tsteur what's your opinion on that?

After reading the last comments I was actually a bit confused. It sound a bit like we are mixing up the visitorId that is generated in javascript tracker and the...