Stefan Giehl

Results 594 comments of Stefan Giehl

Do you also need the detection if it is a bot? Otherwise maybe have a look at https://github.com/piwik/device-detector/blob/master/DeviceDetector.php#L275

Guess in such cases we can only try to group in a useful way, such as `XY series` or in this case maybe we should simply detect all as `3...

@eduardokraus And what is incorrect about that? The `GSA/` in the user agent actually indicates the `Google Search App`. Or isn't that correct?

That might be possible, but which client is it actually using? As mentioned the user agent indicates it is the google (search) app

@sanchezzzhak I wouldn't say we need to implement that into device detector. If someone is using device detector, he can simply map the types in his code. @petertwise Are you...

@petertwise Sorry for the delayed answer. Its possible to overwrite the used device detector in Matomo. This is e.g. already done by the device detector cache plugin. See https://github.com/matomo-org/plugin-DeviceDetectorCache/blob/e7ddda820a6b45552b0f963f318338bf2ef87545/config/config.php#L6 I'll...

It's currently not possible to return the raw model if a commercial model is defined

that's wouldn't be too easy to implement. Many device are using there "commercial model" in the useragent. Some have multiple model versions, that we group together to the same "commercial...

I'm not against returning an additional field that contains the actual match. But I think it will be a lot work to go through all detections and adjust them, so...

@csanclop No, you would need to go through all regexes and check them, there are a lot, that do not include any specific matches, or where only some part is...