react-native-sglistview icon indicating copy to clipboard operation
react-native-sglistview copied to clipboard

Rendering bug when using sectionHeaders

Open mschipperheyn opened this issue 8 years ago • 5 comments

I have a rendering bug that doesn't occur with the normal ListView. It occurs when I use section Headers.

After some scrolling, the items start overlapping each other. I'm assuming that the trick with emptying out invisible boxes is not taking sections into consideration.

screen shot 2016-10-17 at 17 31 59 screen shot 2016-10-17 at 17 31 48

I call SGListView like so

  <SGListView
      ref="sglist"
      automaticallyAdjustContentInsets={false}
      dataSource={this.state.ds}
      renderRow={renderRow}
      contentContainerStyle={this.props.contentContainerStyle}
      stickyHeaderIndices={[]}
      initialListSize={this.props.initialListSize}
      scrollRenderAheadDistance={1}
      pageSize={12}
      scrollEnabled={scrollEnabled}
      onScroll={onScroll}
      scrollEventThrottle={0}
      onMomentumScrollEnd = {onScrollEnd}
      onEndReached={this.handleLoadMore}
      onEndReachedThreshold={70}
      renderSectionHeader={this.props.renderSectionHeader}
      renderFooter={this.renderFooter}
      contentContainerStyle={[localStyle.container,contentContainerStyle]}
      onLayout={this.setListHeight}
      refreshControl={
        <RefreshControl
          refreshing={showRefresh}
          onRefresh={onRefresh}
        />
      }
  />

mschipperheyn avatar Oct 17 '16 19:10 mschipperheyn

Can you verify that using a regular ListView produces the right UI? Thanks.

sghiassy avatar Oct 18 '16 00:10 sghiassy

haha... totally missed your first sentence.

So yeah, this seems like a total bug. Many apologies, but I don't know how I'll have time to tackle it in the short-term.

PRs are greatly appreciated.

Cheers, -- Shaheen

sghiassy avatar Oct 18 '16 00:10 sghiassy

my renderRow method doesn't use sectionId. I'll investigate if this could be the issue. Also, I resort data when new data comes in load-more style. Wonder if this screws with section references somehow.

mschipperheyn avatar Oct 19 '16 12:10 mschipperheyn

hi @mschipperheyn , have you found solution for the bug related to section header ? Please let me know if possible. Thanks

vivekguptaraw avatar Feb 10 '17 06:02 vivekguptaraw

There was an update to the section headers logic in the newest release. Try updating to version 0.4.3

sghiassy avatar Apr 30 '17 04:04 sghiassy