replicad icon indicating copy to clipboard operation
replicad copied to clipboard

Fix TypeScript signature of the emscripten module init function

Open jirihon opened this issue 3 years ago • 4 comments

This fixes TypeScript problem described in issue #54.

The pach adds the missing argument to the init function. For simplicity, the type of the argument is set to any. Exact type could be imported from @types/emscripten. However, introducing new dependency is a serious thing, so I leave the decision to the maintainers of this awesome package.

jirihon avatar Jul 29 '22 07:07 jirihon

Deploy Preview for stupefied-edison-1dae54 canceled.

Name Link
Latest commit bed50d8825c5befd25ceeb6e444a9c540068b362
Latest deploy log https://app.netlify.com/sites/stupefied-edison-1dae54/deploys/62e38abbf386a00008e8aa87

netlify[bot] avatar Jul 29 '22 07:07 netlify[bot]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Jul 29 '22 07:07 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

jirihon avatar Jul 29 '22 07:07 jirihon

This function is generated automatically with opencascadejs - so your commit will be overridden the next time I generate them.

I should update the version I use to generate the bindings (and it should solve it).

sgenoud avatar Jul 29 '22 14:07 sgenoud