Steven Decker

Results 112 comments of Steven Decker

@dopplershift I haven't had a chance to see what numbers the gdxarray method is coming up with internally, but I suspect they are radians based on [this GEMPAK function](https://github.com/Unidata/gempak/blob/e3c61e315d7fdfb87e8d90bed49386b86ced54f9/gempak/source/gplt/transform/gcyllm.f). It...

This is to be expected @wx4stg . The moist adiabatic lapse rate represents a temperature change, not a virtual temperature change. As the parcel ascends, it loses water vapor, so...

Perhaps a discussion of adding units to coordinate arrays a la: https://github.com/Unidata/MetPy/issues/2118#issuecomment-924165240 would be a useful addition as well.

Please let me know if this should be a separate issue, but a student was flummoxed when the following code excerpt: ```python pc = PanelContainer() pc.panel = [panel1, panel, panel3,...

[The classic paper on this subject](https://github.com/jrleeman/CAPE-SciPy-2017/blob/master/Doswell_Rasmussen_1994.pdf) contains a few soundings that could be used as additional test cases, assuming the Wyoming server has them.

I wouldn't expect exact agreement in the numerical value of the CAPE, as it depends on other details of the calculation in addition to whether or not virtual temperature is...

If I'm reading the test cases properly, for instance ``` - (, ) + (, ) ``` using virtual temperature is decreasing the CAPE? I would expect almost always there...

Can you add the parcel temperature to that plot? This actually looks fairly similar to Fig. 2.9 in the Markowski textbook, where CAPE increases from 2872 J/kg to 3108 J/kg,...

[ ] When #1689 is solved, add an attribute that ties into the max/min plotting (akin to the GEMPAK HILO parameter).

> Not having the boolean (`True`/`False`) arguments you have above has been an intentional design decision. [Boolean arguments](https://medium.com/@amlcurran/clean-code-the-curse-of-a-boolean-parameter-c237a830b7a3) are [often](https://ardalis.com/are-boolean-flags-on-methods-a-code-smell/) considered an [anti-pattern](https://martinfowler.com/bliki/FlagArgument.html) or [code smell](https://adamj.eu/tech/2021/07/10/python-type-hints-how-to-avoid-the-boolean-trap/). The short of it...