generator-aspnetcore-angular2 icon indicating copy to clipboard operation
generator-aspnetcore-angular2 copied to clipboard

Update the Code for Angular 2.4

Open AbrarJahin opened this issue 8 years ago • 3 comments

hi, Currently Angular 2.4 is released, but it is depending on 2.1, so I think, code should be updated.

And also, I am finding angular files are in wwwroot folder, but they should be in there, they should be in a seperate folders and build files should be transferred to wwwroot like this repo-

https://github.com/abrarjahin/Dot.NetCore_Angular2_App

AbrarJahin avatar Dec 27 '16 14:12 AbrarJahin

The advanced template relies on Microsoft.AspNetCore.AngularServices for prerendering. From what I've read, Universal doesn't currently work with Angular > 2.1. Supposedly they plan on merging some Universal pieces into Angular Core, which might make it into 4.0.0.

I'll think about what to do in this situation. I'm also open to suggestions.

TBH, I kind of prefer having the src folder in wwwroot, that way all client related assets are kept under wwwroot, but if more people end up wanting it moved, I'll do it.

sgbj avatar Dec 28 '16 01:12 sgbj

I am suggesting to move codes from wwwroot because if u put your code in wwwroot, then if any hacker want to download your code to know more about your API or anything, he can do that easily.

But if you put the code outside wwwroot, then it is more secured.

Thanks for your help.

When you have done upgrading to angular 4, please let me know by giving a reply on this issue.

Thanks

AbrarJahin avatar Dec 28 '16 13:12 AbrarJahin

The project.json file is set to exclude the src and e2e folders when publishing the project, but I understand where you're coming from.

sgbj avatar Dec 28 '16 18:12 sgbj