Silvan Fuhrer
Silvan Fuhrer
I've rabased an current main and then addressed a couple of issues/missing things I found while testing it in SITL and on a real plane. See commit history.
Flight tested again. Couldn't find any issue anymore, and while the rate and attitude tracking isn't yet prefect it was as good as it ever was on this plane, and...
> Great work, just one minor comment on copy-paste reduction You're absolutely right ofc, that was pure laziness. Committed your proposal.
Thanks for the review and the afterthoughts @tstastny ! >main takeaway is that airspeed scaling is not a rate control issue, but tied to the actuator that is either already...
Only looked at the VTOLs and FWs. I would also remove - 13003_quad_tailsitter (if required we can add a generic quad tailsitter, I would rather not) But I would keep:...
> Ok, keeping 13014_vtol_babyshark and removing 13003_quad_tailsitter. @sfuhrer do you want to add A-Tail CS types? Yes make sense, done https://github.com/PX4/PX4-Autopilot/pull/19990/commits/780a39386c52bb297d56dc2b3e46737cf99ddb0c
> Ah I didn't notice that the documentation is already there. It explains the concept quite clearly. I was just not sure why the Cone wasn't enabled for fixed wing...
> I am not sure why this lower boundary logic is there. And the number '2' is quite arbitrary, is there a way of having a better logic for this...
@junwoo091400 can you wrap this up or close it? Thanks!
@hamishwillee can you follow up on the review comments? Thanks!