dataprep
dataprep copied to clipboard
feat(clean): add clean_language function
Description
Implementation of clean_language
as described in #664.
How Has This Been Tested?
By testing the default setting, specifying formats and changing knowledge bases.
Snapshots:
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have already squashed the commits and make the commit message conform to the project standard.
- [x] I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules
Pull request analysis by VIZIPI
Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below ) Feedback always welcome
No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments.
Potential missing files from this Pull request
No files found with a 40% threashold :) No commonly committed files found with a 40% threashold
Codecov Report
Merging #666 (158ca07) into develop (c735cd9) will increase coverage by
0.20%
. The diff coverage is93.96%
.
@@ Coverage Diff @@
## develop #666 +/- ##
===========================================
+ Coverage 84.32% 84.52% +0.20%
===========================================
Files 104 106 +2
Lines 9811 10010 +199
===========================================
+ Hits 8273 8461 +188
- Misses 1538 1549 +11
Impacted Files | Coverage Δ | |
---|---|---|
dataprep/clean/clean_language.py | 88.99% <88.99%> (ø) |
|
dataprep/clean/__init__.py | 100.00% <100.00%> (ø) |
|
dataprep/tests/clean/test_clean_language.py | 100.00% <100.00%> (ø) |
|
dataprep/eda/correlation/compute/overview.py | 99.24% <0.00%> (+0.75%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c735cd9...158ca07. Read the comment docs.