connector-x icon indicating copy to clipboard operation
connector-x copied to clipboard

Support for Trino

Open romanzdk opened this issue 2 years ago • 4 comments

Please add support for Trino SQL engine

romanzdk avatar Jan 27 '23 21:01 romanzdk

+1 on this, I feel like it should not be too difficult given there is already the official DBAPI wrapper https://github.com/trinodb/trino-python-client

antonysouthworth-halter avatar Aug 09 '23 04:08 antonysouthworth-halter

+1, but it seems trino is using http as interface, thus won't be accelerated too much.

zeddit avatar Aug 21 '23 20:08 zeddit

Here's an example Trino Rust client implementation: https://github.com/joshthoward/trino-rust-client, it's basically just a wrapper around a few REST API calls. There are also very tricky things like supporting OAuth and automatically de-serializing the data into an Arrow table format that are absent.

Benchmarking that (as the best case) against the python bindings might show if there is a room for speedup, but I doubt much is to be gained.

wseaton avatar Aug 21 '23 20:08 wseaton