connector-x icon indicating copy to clipboard operation
connector-x copied to clipboard
verified publisher icon sfu-db

Support partition_on on timestamp columns

Open wangxiaoying opened this issue 3 years ago • 4 comments

Describe your feature request

Support partition_on on timestamp columns https://github.com/sfu-db/connector-x/issues/305

wangxiaoying avatar Jul 13 '22 23:07 wangxiaoying

Hi! Is anyone working on this? I'd also be interested in this feature, how could I help?

mvanaltvorst avatar Sep 03 '23 08:09 mvanaltvorst

Hi @mvanaltvorst , thanks for the reply. Currently the logic of partitioning the numeric columns is here. Basically there are three steps:

  1. get min and max value for partition column get_col_range
  2. compute the intervals for query, this part of the logic can be found here
  3. generate partitioned queries get_part_query

Basically we need to be able to support the three steps for timestamp columns too. Please feel free to open a PR for this if you are interested!

wangxiaoying avatar Sep 08 '23 21:09 wangxiaoying

For this issue to be considered solved, should this be implemented in all databases?

surister avatar Feb 01 '24 10:02 surister

Hi @surister , yes I think that would be the ideal case.

wangxiaoying avatar Feb 23 '24 05:02 wangxiaoying