sftse

Results 69 comments of sftse

Since you mentioned four functions it is not clear to me whether you expected those four sets to form a partition. It's possible to have a partition `X = attachments...

The content was truncated to better highlight the structure of the mail. Here's the full example ```text Message-ID: Date: Wed, 17 May 2000 23:08:29 -0400 From: Doug Sauder X-Mailer: Mozilla...

Is there precedent showing contributors need this amount of coaching?

It might make sense to define what the (non-)goals of the guide are, because it's not that clear to me. I would think it's a basic requirement that the necessary...

@jmcnamara I don't think we should merge this in its current state. The commit history is very confusing (empty rebase commits, merge commits inside this PR) and I think the...

It may be easier to visualize what is going on with this PR. `git log --all --graph` may help with orientation for what to merge into what and what a...

I've cleaned up the commit history in my branch [pr-559-clean](https://github.com/sftse/calamine/tree/pr-559-clean), here is what the history would look like if it were merged into master. If you can force push to...

While the API this PR proposes to add is consistent with other optional features like pictures, I think the pattern of adding `Option` to the main struct `Xlsx` is an...

dependency update LGTM

Before merge I want to add the particular, spec-nonconformant `XLUnicodeString` as a unit test.