CppPatterns-Patterns icon indicating copy to clipboard operation
CppPatterns-Patterns copied to clipboard

std::experimental::dynarray no longer supported in array passing example

Open GabrielDougherty opened this issue 5 years ago • 0 comments

Hello, compiling functions/pass-arrays.cpp with GCC 7.3.0 fails with the following error:

gabriel@ubuntu-thinkpad:/tmp$ g++ -std=c++17 dynarr.cpp -o dynarr
dynarr.cpp:3:10: fatal error: experimental/dynarray: No such file or directory
 #include <experimental/dynarray>
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This is due to the inclusion of std::experimental::dynarray. It appears that std:dynarry didn't make it into c++14. Also, the link to std::experimental::dynarray documentation is broken since the page was removed from cppreference.

Would you be interested in removing dynarray from the example? I have submitted PR https://github.com/sftrabbit/CppPatterns-Patterns/pull/74 if you are open to it. Thanks for maintaining this incredibly useful page, I have learned a lot from it!

GabrielDougherty avatar Apr 15 '19 17:04 GabrielDougherty