Tim Bannister
Tim Bannister
> community: updated to the current docs layout provided by the theme as it was the same before. > (The only reason this layout is needed is because all generated...
Also see https://github.com/kubernetes/website/pull/48726
I pulled this locally and found that `make container-server` doesn't succeed. Per https://github.com/kubernetes/contributor-site/pull/531/files#r1827530755, I don't recommend merging this as-is. Here's the error I saw: ``` Error: command error: failed to...
> I personally prefer copying over the source and building inside the container instead of mounting it as that leads to more reproducible builds. It sounds like you recommend copying...
> I can repurpose this PR to go up to 0.5 and create a new PR for 0.10 (or 0.11) Let's repurpose this one. > I can close this PR...
If people want to run `hugo` locally, they can. Or they can preview in a container - as a project, we like containers. CI builds and production deploys are in...
The container image doesn't build for me: ``` STEP 5/8: RUN npm ci npm ERR! code EUSAGE npm ERR! npm ERR! The `npm ci` command can only install with an...
> would it be ok, if I `COPY` over the `package.json` and `package-lock.json` over to the `Dockerfile`. Sure, that's a really common technique for this situation.
> Do you think there is any value in checking in a CI step that the container builds and runs? One for a follow-up PR, and maybe best if we...
Please squash this down to fewer commits; I think that's tidiest.