sfs-matlab
sfs-matlab copied to clipboard
The zeros/roots of the spherical Hankel function of the second kind
https://github.com/sfstoolbox/sfs-matlab/blob/master/SFS_general/sphbesselh_zeros.m find zero and root for the spherical Hankel function of the first kind.
However: % The zeros/roots of the spherical Hankel function of the second kind % can be obtained based on the following relationship. % suppose z = x + iy is a zero for the spherical Hankel function of the first kind. % then z = -ix + y, and z = -ix -y are zeros for the the spherical Hankel function of the second kind.
Please add this to the https://github.com/sfstoolbox/sfs-matlab/blob/master/SFS_general/sphbesselh_zeros.m
Thanks for commenting.
Do you propose to add the comment to the docstring of sphbesselh_zeros
or where do you would expect it?
I want to add to the comments at the start of the file https://github.com/sfstoolbox/sfs-matlab/blob/master/SFS_general/sphbesselh_zeros.m
but I do not have the right to make the modifications.
Thanks, I opened #196 to incorporate your changes.
Note, even if you don't have rights, you can always create a pull request from a fork, see: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork