sflowtool icon indicating copy to clipboard operation
sflowtool copied to clipboard

Release source tarball

Open nunotexbsd opened this issue 2 years ago • 2 comments

Hello,

Could this project provide a release source tarball, e.g, sflowtool-5.0.7.tar.gz to be included toguether with Release Assets?

This have the advantage to download source code from a fixed tarball instead of an auto-generated one: https://github.com/sflow/sflowtool/archive/refs/tags/v5.07.tar.gz.

Since I'm maintaining FreeBSD CopyQ port, instead of using github account name/project to get auto-generated source tarball, I could simply use a simple command to fetch from a static url:

from:

PORTNAME=       sflowtool
DISTVERSIONPREFIX=      v
DISTVERSION=    5.0.7

USE_GITHUB=     yes
GH_ACCOUNT=     sflow
GH_PROJECT=     sflowtool

distinfo:
SHA256 (sflow-sflowtool-v5.07_GH0.tar.gz) = ###
SIZE (sflow-sflowtool-v5.07_GH0.tar.gz) = ###

to:

PORTNAME=       sflowtool
DISTVERSION=    5.0.7
MASTER_SITES= https://github.com/sflow/sflowtool/releases/download/v${DISTVERSION}/

distinfo:
SHA256 (sflowtool-5.0.7.tar.gz) = ###
SIZE (sflowtool-5.0.7.tar.gz) = ###

IMO, all packaging systems that needs fetching and compiling from source will beneficit with this static tarball.

Example: https://github.com/jordansissel/xdotool/releases

Thanks,

Nuno Eduardo Teixeira [email protected]

nunotexbsd avatar Jul 11 '22 07:07 nunotexbsd

Do you want the named tarball file to be exactly the same as the .tar.gz that is in the release assets now? https://github.com/sflow/sflowtool/archive/refs/tags/v5.07.tar.gz

Or do you mean the sflowtool-5.07.tar.gz file that you get when you run this sequence of commands: git clone https://github.com/sflow/sflowtool cd sflowtool ./boot ./configure make dist

sflow avatar Jul 14 '22 21:07 sflow

Well thats the diference of auto-generated tarball and a fixed static one like in https://github.com/jordansissel/xdotool/releases. The main advantage is that port builders like FreeBSD ports framework could access a static tarball without github access (account and project name).

nunotexbsd avatar Jul 15 '22 06:07 nunotexbsd

I put the tarball generated by "make dist" into the 6.02 release assets: sflowtool-6.02.tar.gz. Please let me know if this is what you were looking for. (And sorry this took so long).

sflow avatar Aug 08 '23 21:08 sflow

Comparing git fetch versus tarball, I found some differences:

sflow_xdr.h is missing from tarball (critical, don't build): Only in git/sflowtool-6.02/src: sflow_xdr.h

Only in tarball/sflowtool-6.02: INSTALL
Only in tarball/sflowtool-6.02: Makefile.in
Only in git/sflowtool-6.02: README.md
Only in tarball/sflowtool-6.02: aclocal.m4
Only in git/sflowtool-6.02: boot.sh
Only in tarball/sflowtool-6.02: compile
Only in tarball/sflowtool-6.02: config.guess
Only in tarball/sflowtool-6.02: config.sub
Only in tarball/sflowtool-6.02: configure
Only in tarball/sflowtool-6.02: depcomp
Only in tarball/sflowtool-6.02: install-sh
Only in tarball/sflowtool-6.02: missing
Only in tarball/sflowtool-6.02/src: Makefile.in

Could it be fixed?

Thanks!

nunotexbsd avatar Aug 09 '23 07:08 nunotexbsd

I believe it is fixed now: 'make dist' (in master branch) now includes sflow_xdr.h in the tarball. I replaced the tarball asset in the 6.02 release so it should work now.

The other differences are because from the raw repo-clone you start with "./boot.sh", while from the 'make dist' tarball you go straight to "./configure".

Let me know if I need to change anything else.

sflow avatar Aug 09 '23 20:08 sflow

Tarball is good and update committed ( https://cgit.freebsd.org/ports/commit/?id=abeafb07e548861c4477df576e757a2965620358 )

Thanks!

nunotexbsd avatar Aug 10 '23 11:08 nunotexbsd