Sam Firke

I was just working on this and thought I had the quick fix above. But the fact that `adorn_ns` takes a custom data.frame of `ns` complicates things. Say your custom...

I need to go look at the code but it occurred to me today that it shouldn't be too hard to, at the end of this function, replace any columns...

(the long term fix is to add tidyverse-style column selection to the `adorn_` functions, as discussed in #219)

@c-custer thanks for mentioning your use case with `count()`, that led me to this minimal example to solve: ``` library(dplyr) library(janitor) starwars %>% count(gender, homeworld) %>% slice(1:5) %>% adorn_percentages("col") %>%...

Thanks for the reprex and for finding an existing issue! I think the behavior above is not about having multiple character columns, but instead about passing your custom Ns to...

Thanks for these ideas. I get the appeal of (2) but the argument wouldn't apply to a two-way tabyl, yet it would be added to the function call for `tabyl`...

What if you could pass a string to `show_na` and that would replace the `NA_` with that string? Then it doesn't add an argument.

I like this idea! I don't think it would be hard to implement either, any of these would probably do it: https://stackoverflow.com/questions/6112803/how-to-create-a-consecutive-index-based-on-a-grouping-variable-in-a-dataframe. We probably ought to test them for performance...

It's issue 300! Someone else had previously lamented that `percent` was not technically a correct name. I think it was a Twitter conversation I was only an observer in. Maybe...

I opened a discussion re: the merits of renaming here: https://github.com/sfirke/janitor/discussions/474