Shane F. Carr

Results 402 issues of Shane F. Carr

`normalize_iter` gives us the ability to keep track of the source string indices while generating the output string. I wrote the example using a `RefCell` since the `DecomposingNormalizer` takes ownership...

waiting-on-author

Fixes #2703 Fixes #4914 Mostly fixes #2713 I wrote a test that checks for invariants on calendar behavior. In addition to ISO round-trip, it tests simple day-based calendar arithmetic, which...

DateTimeFormatter is 6.6 KB on the stack. This is because it owns a lot of DataPayloads, which are themselves collections of pointers to strings either in bake data or in...

C-data-infra
C-datetime

#1691 Note that Serde does this differently using `serde(try_from)` (see https://github.com/serde-rs/serde/issues/939). However, since ULE types are dealt with by reference, and there isn't a safe way to transmute `&A` to...

waiting-on-author

We did a bunch of good things for performance of the Chinese calendar in the context of https://github.com/unicode-org/icu4x/issues/3687. We should do similar for Islamic. We should track the benchmarks over...

good first issue
A-performance
C-calendar

Poking around, I keep finding places in icu_calendar where we do the wrong thing with negative numbers. We need to fix this, since one value proposition of ICU4X's calendar crate...

T-bug
good first issue
S-medium
C-calendar

I needed it in DateTimeFormatter for loading cross-component types including FixedDecimalFormatter and WeekCalculator. It looks like Transliterator needs it for loading Normalizer. This pattern with compiled data will continue to...

C-meta
T-techdebt

`day_of_year` is a u16 but `day_of_month` is as u32. Worth fixing? @Manishearth @echeran

C-calendar
2.0-breaking

CLDR-17336 - [x] This PR completes the ticket. I fixed an ambiguous part of the spec where it said component parent locales "inherit" from the root component, only to be...