sfence

Results 108 comments of sfence

Windows build failed due to: ``` CMake Error at irr/src/CMakeLists.txt:267 (message): SDL2 is too old, required is at least 2.0.10! ```

> Also, please take a look at the [Code style guidelines](https://dev.minetest.net/Code_style_guidelines) and adjust newly written code accordingly. (The old code you've only moved can stay as is, that makes reviewing...

@SmallJoker Should be fixed now.

> * I'm a little worried about the `O(player_count * sound_count)` performance of this. I do not know how many sounds are common there per player. Do you have in...

Question for core developers: Situation: Not-looped sound is added to the area with nobody in hearing distance. What do you think should happen? Sound can be short and also long....

@SmallJoker I have tried it with minetest client build without sound. It answer with "done" packet pretty immediately. There will probably have to be added some field to sound parameters...

@appgurueu @Desour The main reason to add `keep_time` was testing with a client compiled without sound support. (https://github.com/minetest/minetest/pull/14342#issuecomment-1930460657) If you play a long sound without `keep_time`, and in the hearing...

@Desour > ```diff > max_hear_distance = 32, > - -- Only play for players that are at most this far away when the sound > - -- starts playing. >...

> I'm still having conceptual concerns about this change. > > * It changes behaviour. Is this fine? > > * `sound_play` being able to fail makes the API overall...

> > So from my side of view `keep_time` can be removed if the client builds without sounds will be removed. > > Note that this is barely possible. If...