Toby Zhang

Results 30 comments of Toby Zhang

> @sfc-gh-tzhang > > > Thanks for the change, two questions: > > > > 1. Could you update SnowflakeStreamingIngestClientInternal.close as well? > > The reason I did not change...

> Actually I think that for the `client.close()` I think that we should chat because I have some questions that I need to clarify before figuring out a solution. For...

> > > @sfc-gh-tzhang > > > > Thanks for the change, two questions: > > > > > > > > 1. Could you update SnowflakeStreamingIngestClientInternal.close as well? >...

> Oh now I see your point. > > I think that the best solution to this is to not expose the `isClosed()` method at all and either make the...

> > > Actually I think that for the `client.close()` I think that we should chat because I have some questions that I need to clarify before figuring out a...

> For the tests now, > > > LGTM, please make sure you pass all the merge gate, as well as `StreamingIngestIT.java` > > Now that we changed the semantics...

> Originally, the idea was to pass the unquoted name from the server side, but it is not enough because we still need to translate between the name entered by...

@sfc-gh-lsembera @sfc-gh-alhuang I want to revisit our decision of **NOT shading the JDBC dependency** after this change, we have seen too many issues that customer is using an older version...

> May be this is already discussed, but can we confirm from jdbc team this is okay to use in production? https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc-2024 release notes says, it is an experimental feature...

Thanks @sfc-gh-alhuang ! No concerns from me as long as @sfc-gh-lsembera signed off, could you wait for release 2.1.1 to go out before merging this change?