quisp icon indicating copy to clipboard operation
quisp copied to clipboard

Split actions into several base actions

Open Chibikuri opened this issue 2 years ago • 1 comments

Close #412


This change is Reviewable

Chibikuri avatar Aug 31 '22 03:08 Chibikuri

Reviewed 26 of 26 files at r2, all commit messages. Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Chibikuri)

quisp/rules/Active/actions/DoublePurifyAction_test.cc line 218 at r2 (raw file):

  EXPECT_EQ(result->getRule_id(), action->rule_id);
  EXPECT_EQ(result->getRuleset_id(), action->ruleset_id);
  // EXPECT_EQ(result->getEntangled_with(), qubit);

remove it because of #416

quisp/rules/Active/actions/base/TransferMessage.h line 7 at r2 (raw file):

namespace quisp::rules::active::actions::base {

class TransferMessage : public BaseAction {

Do we need to make it a class? I don't know the detail of its design, but for now, you should use a "static method." These are just wrappers for creating messages.

I'll remove the class definition here since I don't need it.

Chibikuri avatar Sep 03 '22 06:09 Chibikuri