quisp icon indicating copy to clipboard operation
quisp copied to clipboard

Some messages do not get deleted properly

Open Naphann opened this issue 3 years ago • 0 comments

Describe the bug

From what I can see, there are some messages that aren't deleted after being processed. This can lead to memory leak. I list those I found below

  • LinkTomographyRequest
  • LinkTomographyAck
  • LinkTomogrpahyResult
  • Application: DeleteThisModule message (noted that a the deleteModule() doesn't return the handler to the caller thus message must be deleted before it or it should be deleted inside the destructor) https://github.com/sfc-aqua/quisp/blob/ece6bd972327d913bfb6b76cfe35c9051b45380d/quisp/modules/Application/Application.cc#L89-L93
  • If the code path goes through this branching https://github.com/sfc-aqua/quisp/blob/ece6bd972327d913bfb6b76cfe35c9051b45380d/quisp/modules/QRSA/RuleEngine/RuleEngine.cc#L129-L132
  • endTxEvent messages

There must be more types/places but I only found these for now.

Naphann avatar Sep 07 '21 01:09 Naphann