bats-server icon indicating copy to clipboard operation
bats-server copied to clipboard

Maintain collapsed state of Ringdowns list when switching tabs in ER view

Open kretzbryan opened this issue 2 years ago • 2 comments
trafficstars

kretzbryan avatar Feb 26 '23 22:02 kretzbryan

Thanks for this, @kretzbryan. I'm not sure writing the state to localStorage is the best approach, as we'd be leaving behind the title of each ringdown in the browser, and there's no guarantee they'd be unique. Seems like the app itself would need to maintain the state. Or the tab could just be hidden, instead of torn down, so the expanded state would be maintained in the DOM.

fwextensions avatar Feb 28 '23 01:02 fwextensions

I'm not sure if we're going to have other ui features related to the ringdown sections, so I structured the state so we can add more values to each section. If you think all we're expecting is to expand them, then I can simplify the state a little more.

kretzbryan avatar Mar 02 '23 22:03 kretzbryan