sfan5
sfan5
Has anyone tried to verify how well this matches our code style by running it on existing files? If not I will.
Here's it applied to a few big files: https://github.com/sfan5/mpv/commit/bf400f2bd6c02b25a1e9d9c8ccd9d05f3d3bab93 As I feared, either the config is not fitting or clang-format is just too opinionated to be applied to all new...
here's it again: https://github.com/sfan5/mpv/commit/c80a70c4fae449eaf1f858699d10ca95617af7fa most of the changes are fine, however the obsessive "let's align everything" is weird. also why this? ```diff - in->d_thread->params = params; // temporary during open()...
> Why not? It's somewhat common to separate comments. Personally I find one space nicer, but also this isn't just part of our code style. contribute.md talks about "K&R style"...
As far as I can tell this affects IPv4 equally. I noticed that nspawn containers started with `--network-veth` would no longer have working internet access unless I manually set `net.ipv4.ip_forward=1`....
I think the reason this does not exist is because shrinking is a lossy operation. What's the use case here?
Clipboard handling is not (yet) supported on X11, so this won't work on your setup. I agree mpv shouldn't quit without explanation however.
So what are the reproduction steps? If I launch mpv in a terminal to play a video, there is nothing noticeable.