feiertagejs icon indicating copy to clipboard operation
feiertagejs copied to clipboard

Type property "regions" missing for type Holiday

Open chrschae opened this issue 10 months ago • 1 comments

Hey,

I just want to remark that the property "regions" seems to be missing for the type Holiday.

In my case i noticed it when using const holiday = getHolidaysByDate(date,region) that the property "regions" is missing.

chrschae avatar Apr 10 '24 13:04 chrschae

Hi @chrschae , I reviewed your case and added unittest in this commit to reproduce the situation:

https://github.com/sfakir/feiertagejs/commit/d67dd022832b245c58f54abe649a6c3fbb2217db

Basically the property "regions" is set for the holiday type. Could you give me some more information - maybe the specific holiday?

Please note: if there is no holiday found the response would be void, and then regions is not available.

Hope this helps.

sfakir avatar Jun 14 '24 08:06 sfakir