r2d2 icon indicating copy to clipboard operation
r2d2 copied to clipboard

Add ability to use Mutex / Condvar from std.

Open BratSinot opened this issue 2 years ago • 9 comments

Fix #138

BratSinot avatar Feb 20 '23 11:02 BratSinot

Would be great if this gets merged.

SamTV12345 avatar May 20 '23 23:05 SamTV12345

What is the point of doing this?

If we're going to support non-parking-lot mutexes this should use antidote rather than reimplementig non-poisoning locks manually.

sfackler avatar May 21 '23 02:05 sfackler

I took a look at this crate. It's more or less the same code. So the question is what would be more comfortable for you? Maintain two projects or one. These two approaches are better than parking lot with their own dependencies.

SamTV12345 avatar May 21 '23 06:05 SamTV12345

What is the point of doing this?

sfackler avatar May 21 '23 11:05 sfackler

See above

SamTV12345 avatar May 21 '23 11:05 SamTV12345

Why are these two approaches better than parking lot with its own dependencies?

sfackler avatar May 21 '23 11:05 sfackler

Because having other dependencies means they need to be compiled during build which means longer build times. If this is already included in the stdlib this would not be the case and I could get a smaller docker image.

SamTV12345 avatar May 21 '23 11:05 SamTV12345

How much does this change affect your build times and docker image size?

sfackler avatar May 21 '23 12:05 sfackler

Enough that I want to have as few dependencies as possible.

SamTV12345 avatar May 21 '23 14:05 SamTV12345