android_vendor_extendrom icon indicating copy to clipboard operation
android_vendor_extendrom copied to clipboard

Libraries of GmsCore.apk are not extracted

Open petefoth opened this issue 2 months ago • 2 comments

Reproduction steps / Problem description

  1. Make a build with extendrom that includes MicroG GmsCore
  2. Install the ROM
  3. Boot and go through Setup Wizard
  4. Enable rooted debugging
  5. adb root
  6. adb shell
  7. ls -al /system_ext/app/MicrogGmsCore_GH_PRERELEASE/ (directory name dependent on which GmsCore package you used)
  8. Expected behaviour: there should be a lib/ sub-directory containing the .so files extracted from the `apka
  9. Actual behaviour: there is no sub-directory, and no .so file, only the apk

See this issue in/lineageos4microg/android_vendor_partner_gms repo for more background.

Looking at the builds I have made with extendrom (see #55) there is still no lib/ directory in system_ext/app/MicrogGmsCore_GH_PRERELEASE/ only the apk. So I guess the problem raised in #57 is also a problem for extendrom?

# ls -al /system_ext/app/MicrogGmsCore_GH_PRERELEASE/
total 223992
drwxr-xr-x  2 root root      4096 2009-01-01 00:00 .
drwxr-xr-x 12 root root      4096 2009-01-01 00:00 ..
-rw-r--r--  1 root root 230877671 2009-01-01 00:00 MicrogGmsCore_GH_PRERELEASE.apk

Originally posted by @petefoth in #57

Device vendor

No response

Custom OS

los4microG

OS version

14

extendrom log

n/a

Build log

No response

extendrom's Android.mk

No response

Free form for additional info

No response

petefoth avatar Oct 22 '25 13:10 petefoth

while this should not be a big deal to activate (switch to PRESIGNED-extractlibs), I would like to see that this is really required (like a specific app which crashes without this).

as mentioned in that other issue I never saw any issue related to not extracting it and my assumption is that users of my OS builds would report that quickly. so if we can re-produce a crash which then can be fixed by that it would help a lot.

steadfasterX avatar Oct 23 '25 06:10 steadfasterX

I don't plan to fix it in our repo, because

  1. I have no idea how to fix it in our repo;
  2. I haven't ever seen an problem reported with our builds: at the moment, from our perspective, the issue is 'theoretical': it isn't broken (in any way that affects users) so we won't change it;
  3. we will be forced to change how we get the extra components because from 0.3.10 onwards, microG will be too big to store in our github. With kuck we can get round that using extendrom at which point it becomes your (theoretical) problem, not ours. 😉

I'll leave our issue open, but I will probably mark it as 'Won't fix' when / if we are producing working builds using extendrom.

petefoth avatar Oct 23 '25 07:10 petefoth