EJ Song

Results 92 comments of EJ Song

Since we only allow 1 relation and the current plan signature of non-hybrid scan is just using "Relation" node, I think we don't need to consider the query plan(Relation) for...

@paryoja Could you update the documentation for IntelliJ/scalafmt? while you're setting up it :)

@andrei-ionescu I've skimmed overall XSkipper codebase and I don't think we could easily plug it in. We are planning to support similar features - BF, (min/max), partition elimination index (similar...

@thugsatbay Could you add BFFilterIndexRule to apply BF index & measure the performance? (for e2e prototype) I wonder file-level BF & filtering files would be beneficial if we use parquet...

@clee704 The API name was changed during the code review :) It's statistic API for an index.

@imback82 @rapoth @apoorvedave1 @thugsatbay Though this change will be a breaking change, I think we need this sub root dir to avoid any kind of interference. We shouldn't rely on...

- we might have some metadata later - if there's other directories in there, index manager tries to find or build IndexLogEntry on it and causes some exception, or directory...

@andrei-ionescu That's a fair point but currently Hyperspace doesn't have "metadata" dir and rely on the directory structure under the system path; so I suggest this sub-root dir. We don't...

@andrei-ionescu Yep sounds good to me. Thanks for the good suggestion :) @rapoth any opinion on this PR?

@imback82 Now at least we have a workaround ( indexDirName = "" ) for the breaking change. WDYT?