nps icon indicating copy to clipboard operation
nps copied to clipboard

fix: deprecation warning on Windows

Open mohd-akram opened this issue 10 months ago • 4 comments

spawn-command-with-kill uses an outdated version of spawn-command which causes a deprecation warning to be printed when running scripts due to the latter's use of util._extend.

What:

Why:

How:

Checklist:

  • [ ] Documentation N/A
  • [ ] Tests N/A
  • [x] Ready to be merged
  • [ ] Added myself to contributors table

mohd-akram avatar Feb 10 '25 14:02 mohd-akram

@sezna Did you get a chance to look at this? We run on many Windows machines and there's a glaring red warning every time a script is run, would be nice to have this fixed. I realize this package hasn't been updated in some years, but maybe this PR and #231 can be included in a patch release. I haven't encountered any other visible issues thus far.

mohd-akram avatar Feb 17 '25 14:02 mohd-akram

It looks like the actions are hanging. I'll take a look at that and then get this PR in.

sezna avatar Feb 18 '25 15:02 sezna

@sezna Were you able to figure out the issue? I see the project is still using Travis CI, I'm not sure if that still works, but it might be easier to switch to GitHub Actions.

mohd-akram avatar Feb 25 '25 14:02 mohd-akram

Any update on this?

mohd-akram avatar Apr 03 '25 07:04 mohd-akram