nps icon indicating copy to clipboard operation
nps copied to clipboard

Offering to maintain nps

Open mf-bruce opened this issue 2 years ago • 6 comments

First off, thanks @sezna for building nps in the first place! We have been using it at Markforged for some time now, and have found it to be elegant in its simplicity, whilst providing just enough functionality to be incredibly powerful!

It seems that nps has lacked maintenance for some years now, there are outstanding security issues, and feature requests such as positional args (something we have implemented in our fork).

We would like to offer to maintain the nps package, so opening this issue to start that conversation!

mf-bruce avatar Apr 28 '22 12:04 mf-bruce

Yeah, I took over because my previous job was using it and it wasn't being maintained. Now, I'm no longer in that role and I haven't had the time to give it any love. Happy to find somebody who is willing to give it the love it needs!

sezna avatar Apr 28 '22 13:04 sezna

Awesome! How do we go about transferring this? Would it make sense to transfer the npm package ownership so we can publish from our repo moving forward?

mf-bruce avatar Apr 28 '22 19:04 mf-bruce

@mf-bruce have you taken over the project?

Melmoth-the-Wanderer avatar Jun 08 '22 09:06 Melmoth-the-Wanderer

Yep, you can find our fork

Would be nice to transfer the original package name on npm, or at least deprecate it. FYI it's possible the npm deploy key for the original package was leaked via travis:( https://arstechnica.com/information-technology/2021/09/travis-ci-flaw-exposed-secrets-for-thousands-of-open-source-projects/

mf-bruce avatar Jun 09 '22 13:06 mf-bruce

@sezna the current status quo will work fine for folks who proactively want to use a newer version of nps but there are some things we can do to smooth the transition for users who just have "latest" specified in package.json, or new folks discovering this package. Raising these here as I will need some assistance from yourself if we are going to execute on them.

  • Transfer issues to our fork ** I would need write access to this repo to transfer issues)
  • Set our fork as the root repo for other forks ** I asked github support about this and they need you to additionally submit a ticket which references ours
  • Archive this fork
  • Transfer ownership of the nps npm package to us

mf-bruce avatar Jun 10 '22 13:06 mf-bruce

I stumbled upon this package today and found it very interesting. But looking at the last commit almost 2 years ago, was hesitant to pick it up. Until I saw this issue. Great job @mf-bruce to keep it going.

I would personally like to see mf-bruce's fork merged over here so that star ratings can be maintained. There is a lot of equity build into the stars and the downloads - would be sad to loose it all. Also, there is the complication of moving the issues and all. @senza, in the best interest of the community, please consider merging mf-bruce's fork here and giving him permissions to publish on npm. You both can co-own the package (or may be create an org for it).

P.S. I also see @kentcdodds on the contributor's list, so this has to be good :-)

nareshbhatia avatar Aug 09 '22 14:08 nareshbhatia