edi
edi copied to clipboard
sezna
transaction_name to Cow for serialization
I'm working on some python binding for this lib and was running into errors when trying to deserialize the equivalent python edi document object into an EdiDocument with serde.
invalid type: string [...] expected a borrowed string
Found a few other github issues related to serde and &str. Example. Any input would be appreciated. Everything seems to work just fine with a Cow instead of &str. Figured I'd submit the PR and see if you are open to merging upstream. Otherwise I will maintain a fork.
I apologize for missing this, I must have cleared the notification!
I just requested one change, then this should be good to go @lenzo202 😄
Would you need a new version of this published for your use case? Happy to push that out as well.
Would you need a new version of this published for your use case? Happy to push that out as well.
Would love one if you can. Let me know if/when it is published and I can update deps in my python bindings repo. I plan to publish these bindings to pypi if you are ok with that? We saw a 75x performance improvement for parsing a file to python objects compared to the most popular pure python library!