uhexen2 Sunstaff issue

https://github.com/sezero/uhexen2/blob/89191f6e252061eb330d961f14e81eef76bcf36b/gamecode/hc/h2/sunstaff.hc#L225-L233

There's a visual bug with the sunstaff that dates back to the original HexenC releases. If sunstaff is in firing animation, fire key is released and weapon is changed quickly, the EF_BRIGHTLIGHT effect will stay on indefinitely.

Adding

self.effects(-)EF_BRIGHTLIGHT;

on line 231 of sunstaff.hc seems to fix this. I haven't noticed side effects. See attached demos. sunstaff_bug.zip

Feb 16 '24 18:02 tallustelija

I can see it in the demos, but I can't reproduce the thing: How do you so quickly switch to a different weapon to trigger this?

Feb 16 '24 18:02 sezero

Never mind, I did manage to reproduce using mouse scroll to switch weapons.

Feb 16 '24 18:02 sezero

Don't know whether I want to fix it, though. I'd like to make a release soon (I hope.. after 6 years...)

Feb 16 '24 18:02 sezero

Alright, yeah it isn't a high priority bug.

Works as a free torchlight effect which is nice :)

Good luck with the next version release!

Feb 17 '24 12:02 tallustelija

Alright, yeah it isn't a high priority bug.

Indeed

Works as a free torchlight effect which is nice :)

:smile:

Good luck with the next version release!

Thanks

Feb 17 '24 15:02 sezero